Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phrase emphasis not italicized #850

Merged
merged 4 commits into from
Jul 15, 2018
Merged

Fix phrase emphasis not italicized #850

merged 4 commits into from
Jul 15, 2018

Conversation

endiliey
Copy link
Contributor

Motivation

Fix #822

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Change first word of getting-started-installation.md to

*Docusaurus*

before

after

Related PRs

#757

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 14, 2018
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 14, 2018 •
edited
Loading

Deploy preview for docusaurus-preview ready!

Built with commit 19daf71

https://deploy-preview-850--docusaurus-preview.netlify.com

yangshun
yangshun suggested changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to the base CSS. @endiliey could you help add this to line 117 just below strong { ... }

em {
  font-style: italic;
}

yangshun
yangshun approved these changes Jul 15, 2018
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding <i> as well! I had half a thought to add it in but later decided to leave it out because <i> is not encouraged. But since you added it let's leave it in and be consistent with browser styling.

@yangshun yangshun merged commit 03e237a into facebook:master Jul 15, 2018
@endiliey endiliey deleted the emphasized branch July 15, 2018 06:02
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endiliey @docusaurus-bot @yangshun @facebook-github-bot